test: add macOS and Windows tests #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable macOS tests Add TODO Try Windows Fix job name Use setup-go@v4 Read Go version from go.mod Add CWD Fix go-version-file Use ./go.mod Use github.workspace Reorder Spaces Remove cwd Try CD Test Again Again Use localhost IP Add bench Refactor test Add bench Again Re-enable
You mean Windows build and test is slower than macOS and Linux? |
jyyi1
approved these changes
May 2, 2023
There was a problem hiding this comment.
PR title should be test: ..., since test is a valid conventional commit type
fortuna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make sure we stay cross-platform.
Note that the Windows build and test is a lot slower than Linux and Windows. Because of that, I had to change the wait in one of the tests.
Also, I'm using windows-2019, which is at least 2x faster than windows-latest: actions/runner-images#5166
On macOS, I ran into an issue where CloseRead on a connection that was already fully read causes an error, so I needed to update the test there too. It was a huge pain to figure out what was going on.